txAdmin icon indicating copy to clipboard operation
txAdmin copied to clipboard

refactor(menu/spectate): general cleanup + cycling feature

Open TasoOneAsia opened this issue 3 years ago • 3 comments

This cleanups up our spectate system a little bit to hopefully help with readability and logic flow.

But, much of it still relies heavily on side effects that make me weep :(

This also adds the ability cycle between players as a feature, so users wouldn't have to click on each individual player in order to spectate them.

Still needs to be tested for bucket compatibility and a few things I may have missed while writing.

TasoOneAsia avatar Feb 27 '22 00:02 TasoOneAsia

~~Missed this when writing, but it appears I may have mixed up the Jooat hashes that target dynamic key mappings. These just need to be switched around~~

TasoOneAsia avatar Feb 27 '22 00:02 TasoOneAsia

Ready for scale testing.

TasoOneAsia avatar Feb 28 '22 21:02 TasoOneAsia

Any news? Waiting for something special or? :D

TheFantomas avatar Dec 05 '22 08:12 TheFantomas

Any news? Waiting for something special or? :D

First we need to wait for Cfx to ungag the monitor resource, otherwise we would have real hard time diagnosing any errors in this script.
Also conflicts, there are many conflicts in this PR.

tabarra avatar Dec 05 '22 08:12 tabarra

Used these changes, and rewrote a bit, then merged in e195017928f20d17a7d02e3d62b63da5c459dead

tabarra avatar Apr 01 '23 00:04 tabarra