Toni Tabak
Toni Tabak
This is fine, but we need either tests or at least documentation examples of how the devs would use it.
> I don't think the `ArgsOrCalldataWithOptions` type is accurate, the `ContractOptions` object is used as a concatenation to the regular parameters of the encapsulated method and these get passed to...
OK i belave at least now i fixed type
I agree focused on this pr to fix type and new one to propose solution
Closing this one in the favor of the new CairoType Classes
Until we can deterministically define rpc version on the endpoint and get it every time, we will put this on hold. Linking closed PR for reference on @PhilippeR26 tests. https://github.com/starknet-io/starknet.js/pull/1379
We should add documentation for OutsideExecution usage
I haven't gone into details yet, on first look, it seems good, but we need tests. Can you please add tests for new Classes and Batch requests, we must have...
@dhruvkelawala @janek26 @xJonathanLEI I think this should be considered on the spec level?
@dsperac refactor and close this one