tModLoader icon indicating copy to clipboard operation
tModLoader copied to clipboard

Make menu themes persist on restart

Open PlazmaKG opened this issue 2 years ago • 8 comments

Do you intend to personally contribute/program this feature?

No

I would like to see this change made to improve my experience with

Gameplay as a Player

Description

Make the "Change Menu Theme:" option that users can change on the main menu persist between game restarts.

What does this proposal attempt to solve or improve?

It aims to have a customization option persist. It's kind of a useless feature otherwise

Which (other) solutions should be considered?

No response

PlazmaKG avatar Jan 09 '24 02:01 PlazmaKG

I just tested with the ExampleMod menu and it restores itself as the selected menu once mods load. I think the feature is working as intended. (I don't think the vanilla menu options (1.3 terraria logo, 1.4 terraria logo) are intended to restore automatically since those are basically easter eggs, only modded menus.)

JavidPack avatar Jan 09 '24 03:01 JavidPack

When I set the munu theme to "Journey's End" instead of tModLoader, it does not persist.

I want the vanilla logo rather than tmodloader one.

Maybe it's an easter egg but it seems like it'd be cool if it persisted rather than defaulting to a mods menu or the tmodloader one on every startup.

PlazmaKG avatar Jan 09 '24 03:01 PlazmaKG

I believe the intended behavior has always been to not save the vanilla logos, but I'd also prefer saving the Journey's End logo at the very least (not saving the 1.3 logo is fine to preserve the easter egg). +1

steviegt6 avatar Jan 09 '24 18:01 steviegt6

@Chicken-Bones Does this seem fine? Allowing the Journeys end menu selection to persist.

JavidPack avatar Jan 10 '24 23:01 JavidPack

Yes, just have to make sure that the current behavior is maintained when a modded menu was selected. Please test reloading, as well as skip loading on startup (hold shift). I'm not sure whether the latter clears the selected menu currently.

Chicken-Bones avatar Jan 11 '24 00:01 Chicken-Bones

Has work been started on this? I'd be happy to make a PR if it hasn't.

steviegt6 avatar Jan 17 '24 18:01 steviegt6

Has work been started on this? I'd be happy to make a PR if it hasn't.

I have not seen anyone work on this, so it should be open for you to implement.

JavidPack avatar Jan 17 '24 18:01 JavidPack

I have a solution, will open a pr now /claim

Metratrj avatar Feb 24 '24 20:02 Metratrj