Dev Wings drop pre-hardmode in getfixedboi seed

[Solxanich]

Version

Latest 1.4.4-stable

OS

Windows

Platform

Steam

This bug affects

Gameplay as a Player

Description

Title.

https://discord.com/channels/103110554649894912/1133563329286262835/1133563329286262835

Log File

No response

Steps to reproduce

No response

Expected Behavior

No response

Actual Behavior

No response

Reproduction frequency

No response

Additional Information

No response

[direwolf420]

1.4.2.3 added the celebrationmk10 seed (which is part of getfixedboi). The behavior of prehm boss bags dropping dev sets was introduced there as a feature of that seed. in 1.4.4 however, this was reverted. TML refactored item loot and dev set drop code at one point by adding ItemID.Sets.PreHardmodeLikeBossBag which controls this behavior.

I propose a change of naming for the set to BossBagDoesNotDropDevSets or a flat out removal. A tModPorter rule will need to be added to convert this and add a refactoring comment for modders that says "remove it if you don't intend to make it drop dev sets in pre-hardmode".

Thus the issue should be renamed to say celebrationmk10 and not getfixedboi

[ZeroRin]

just run into the problem recently. to my understanding this might be the cause? Main.tenthAnniversaryWorld is in the condition

https://github.com/tModLoader/tModLoader/blob/6bdb2e2520931ac6b03b6102eab7f6e7cce9f635/patches/tModLoader/Terraria/Player.cs.patch#L1397-L1399