gomft icon indicating copy to clipboard operation
gomft copied to clipboard

Thank you

Open joonas-fi opened this issue 3 years ago • 7 comments

I just want to say, that I've seen and produced a truckload of Go code, and the overall code quality of this library is very, very good!

A few highlights:

  • The code is self-documenting,
  • The package structure is sensible, e.g. boot sector stuff in own package
  • I would've had to build a "fragment reader" myself, but you had it ready. It was a joy. :)
  • Where you saw fit to add comments, they were truly for need like this line https://github.com/t9t/gomft/blob/f64df3912ca98b2abeaa2f9e79f7c8a59b159ba9/mft/mft.go#L378 (when I saw that I immediately realized what the bug in my software was)

Good job! You rock.

Sorry to spam issue tracker, I couldn't find other contact details :)

joonas-fi avatar Mar 10 '21 15:03 joonas-fi