atom-vim-mode-plus icon indicating copy to clipboard operation
atom-vim-mode-plus copied to clipboard

Published 20 hours ago • verified publisher icon t9md

Add setting for allowing/preventing search to wrap around

Open johnckendall opened this issue 7 years ago • 2 comments

Simple option to prevent search wraparound like the vi option: set nowrap and set wrap

johnckendall avatar Sep 29 '17 17:09 johnckendall

Why did you change repository reference? I can not get your intention. Also, I think your PR have following caveat.(not confirmed, just from code-read).

  • When there is no match in forwarding direction, it return last match(it should return nothing).

Also I need test spec before merging this(this is depending on content of changes, I sometime accept test-less PR).

t9md avatar Oct 15 '17 09:10 t9md

Sorry, new to this; first PR. I will look into creating a test spec.
About the repo reference; I thought I needed to do this to make sure I get my version locally? Still not sure how this stuff works I guess. Regarding the last match behavior; I left it that way because I like the way it works! ;-) I suppose I could add another option switch to turn it off if you think it is needed. (sorry for late reply, i've been on a cruise in the gulf for last 10 days)

johnckendall avatar Oct 25 '17 12:10 johnckendall