atom-inline-git-diff icon indicating copy to clipboard operation
atom-inline-git-diff copied to clipboard
verified publisher icon t9md

Display word diff correctly when more than one word is modified in a line,

Open alpianon opened this issue 6 years ago • 2 comments

When more than one word is modified in a line, word differences are not displayed correctly (it highlights everything from the first modified word to the last modified word, instead of showing single word differences)

alpianon avatar Mar 07 '19 21:03 alpianon

OK, I'm getting to remember the code of this project(since I've been long-time off from this project).

Now I can say it's intentional, as far as I remember original code used diff npm library to achieve what you are requesting, but I remember it makes output really mess.

https://github.com/samu/git-diff-details/issues/75

So, I want to close this issue with WONT FIX, but before that If you give me some example, I can discuss about it more practically.

t9md avatar Mar 10 '19 05:03 t9md

This is when I removed use of diff lib.

https://github.com/t9md/atom-inline-git-diff/commit/34adc10b4c9fd90e79b4434732e4f5a383e78fcc

I think the removed code is similar to the one in your PR.

t9md avatar Mar 10 '19 06:03 t9md