Michael Telatynski

Results 435 comments of Michael Telatynski

Duplicate of https://github.com/element-hq/element-web/issues/26239

@BillCarsonFr the canonical source for labels is a [YAML fil](https://github.com/element-hq/element-web/blob/develop/.github/labels.yml)e, otherwise it'll be deleted by the automation.

> WTF is a HOC https://legacy.reactjs.org/docs/higher-order-components.html > and why is it better than a Context object? It is a Context object, just passed like a normal prop with normal types...

> Ok, fair enough, but probably we could helpfully write in MatrixClientContext's documentation that you probably want a withMatrixClientHoc rater than directly referring to MatrixClientContext? There's no reason to use...

Thanks for the review. Don't have that much time to spend on this anymore. Will close it until someone from the wysiwyg or compound teams can resume it for their...

Likely the implementation needs updating. Instead of `/_matrix/client/r0/rooms/$roomId/state` you can try https://github.com/matrix-org/matrix-spec-proposals/pull/3266 on certain servers which will return a near-constant-size payload with things like name & number of users in...

> Do you have an idea of how many servers out there have that endpoint? I wouldn't be able to tell you that > Is it basically just matrix.org? No,...

> I find this response dismissive. Not the intent, just trying to help you find a solution which is indeed not ideal for this interim. > As an outsider, I'm...

> but that would also take one or two round-trips off in many cases when using the existing approach. And also being a nicer citizen to the servers which you...