create-t3-turbo icon indicating copy to clipboard operation
create-t3-turbo copied to clipboard

bug: `pnpm i` doesnt install `@acme/api`

Open violetbee opened this issue 2 years ago • 32 comments

image

the other packages are okay

violetbee avatar Nov 26 '22 11:11 violetbee

Where's this error?

juliusmarminge avatar Nov 26 '22 14:11 juliusmarminge

image

I didnt make any change on boilerplate, just did pnpm i

violetbee avatar Nov 26 '22 14:11 violetbee

Works on my end

https://user-images.githubusercontent.com/51714798/204094449-f61276c2-2e0e-4cda-8628-a5e0910c1282.mp4

juliusmarminge avatar Nov 26 '22 14:11 juliusmarminge

https://user-images.githubusercontent.com/51714798/204094619-13537a24-2686-40fe-a245-43d883e4d1bf.mp4

After a clean install

juliusmarminge avatar Nov 26 '22 14:11 juliusmarminge

CleanShot.2022-11-26.at.15.43.02.mp4 After a clean install

I dont know what is happening, I have tried for 3 times, cloning repo and then pnpm i. nothing different

violetbee avatar Nov 26 '22 14:11 violetbee

I have checked node_modules and couldnt find folder like acme

violetbee avatar Nov 26 '22 14:11 violetbee

This is my node_modules in the expo app

CleanShot 2022-11-26 at 16 14 26@2x

What pnpm/node version are you on?

juliusmarminge avatar Nov 26 '22 15:11 juliusmarminge

node v16.16, pnpm v7.17.0

violetbee avatar Nov 26 '22 15:11 violetbee

I was thinking that pnpm would automatically install dependencies directly from the yaml file. I had to pnpm i all the folders one by one, that way there is no problem.

violetbee avatar Nov 26 '22 15:11 violetbee

I was thinking that pnpm would automatically install dependencies directly from the yaml file. I had to pnpm i all the folders one by one, that way there is no problem.

That's really strange, should work no matter where you install

juliusmarminge avatar Nov 26 '22 17:11 juliusmarminge

I was thinking that pnpm would automatically install dependencies directly from the yaml file. I had to pnpm i all the folders one by one, that way there is no problem.

That's really strange, should work no matter where you install

Actually I am still having issue :) image image

Look at it, I did change only pnpm dev from ios to android

violetbee avatar Nov 26 '22 17:11 violetbee

Have you tried making a clean install and see if it's there on a new project too?

I am not sure what else you can do. I can't reproduce this on my end

juliusmarminge avatar Nov 26 '22 17:11 juliusmarminge

Yes, that one was the exact same as the create-t3-turbo clone, I am going to try it on macos later. I have tried atleast :D

violetbee avatar Nov 26 '22 17:11 violetbee

I was thinking that pnpm would automatically install dependencies directly from the yaml file. I had to pnpm i all the folders one by one, that way there is no problem.

That's really strange, should work no matter where you install

And I wanted to add something more, It only skips "link:" folders while installing with pnpm i

violetbee avatar Nov 26 '22 17:11 violetbee

I wonder if this is a vscode issue, might sound retarded, but I had a similar issue as I am on Linux, but if you do cntrl + shift + p then search reload and do a dev reload window, might work. Again I'm just throwing other ideas @violetbee

soya-miruku avatar Nov 27 '22 05:11 soya-miruku

I wonder if this is a vscode issue, might sound retarded, but I had a similar issue as I am on Linux, but if you do cntrl + shift + p then search reload and do a dev reload window, might work. Again I'm just throwing other ideas @violetbee

It didnt work for me :D

violetbee avatar Nov 27 '22 08:11 violetbee

@violetbee Are you using Windows? Could you check if a turbo.exe exists somewhere in your node_modules dir after pnpm i? If not: What kind of antivirus program running on your system?

teddybee avatar Nov 30 '22 14:11 teddybee

@teddybee I am using window's default antivrus program and there is not turbo.exe inside node_modules dir after pnpm i

violetbee avatar Nov 30 '22 15:11 violetbee

@violetbee That means, the turborepo's exe is moved to quarantine. Try to update your antivirus, remove your node modules and do pnpm i again. This helped for me.

teddybee avatar Nov 30 '22 16:11 teddybee

@teddybee I double checked and there is a turbo.exe, antivirus program didnt move quarantine the exe file

violetbee avatar Nov 30 '22 20:11 violetbee

image I have the same problem. device:m1 mac @juliusmarminge

msasen avatar Dec 02 '22 07:12 msasen

Same with me, I tried cloning the project to mac air m1 and then did [pnpm i]. The linked packages are still not installed.

violetbee avatar Dec 02 '22 09:12 violetbee

Still can't reproduce this. Here's a clip where I clone and init locally: https://share.cleanshot.com/aXuxQv.

node_modules still containing the api:

CleanShot 2022-12-05 at 02 07 50@2x CleanShot 2022-12-05 at 02 08 35@2x

juliusmarminge avatar Dec 05 '22 01:12 juliusmarminge

Oh I'm also on Mac btw:

  System:
    OS: macOS 13.0.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 307.55 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.11.0 - ~/Library/Caches/fnm_multishells/78534_1670065369368/bin/node
    npm: 8.19.2 - ~/Library/Caches/fnm_multishells/78534_1670065369368/bin/npm
  Browsers:
    Chrome: 108.0.5359.94
    Firefox: 107.0
    Safari: 16.1
  npmPackages:
    typescript: ^4.9.3 => 4.9.3
$ pnpm -v
7.17.0

juliusmarminge avatar Dec 05 '22 01:12 juliusmarminge

This is really interesting. https://youtu.be/eCh2G9AQyjs

$ pnpm -v 7.17.0 device: mac m1.

Oh I'm also on Mac btw:

  System:
    OS: macOS 13.0.1
    CPU: (8) arm64 Apple M1 Pro
    Memory: 307.55 MB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.11.0 - ~/Library/Caches/fnm_multishells/78534_1670065369368/bin/node
    npm: 8.19.2 - ~/Library/Caches/fnm_multishells/78534_1670065369368/bin/npm
  Browsers:
    Chrome: 108.0.5359.94
    Firefox: 107.0
    Safari: 16.1
  npmPackages:
    typescript: ^4.9.3 => 4.9.3
$ pnpm -v
7.17.0

msasen avatar Dec 05 '22 19:12 msasen

This is really interesting.

https://youtu.be/eCh2G9AQyjs

$ pnpm -v

7.17.0

device: mac m1.

Oh I'm also on Mac btw:

System:

OS: macOS 13.0.1
CPU: (8) arm64 Apple M1 Pro
Memory: 307.55 MB / 16.00 GB
Shell: 5.8.1 - /bin/zsh

Binaries:

Node: 18.11.0 - ~/Library/Caches/fnm_multishells/78534_1670065369368/bin/node
npm: 8.19.2 - ~/Library/Caches/fnm_multishells/78534_1670065369368/bin/npm

Browsers:

Chrome: 108.0.5359.94
Firefox: 107.0
Safari: 16.1

npmPackages:

typescript: ^4.9.3 => 4.9.3

$ pnpm -v

7.17.0

Vid's private

juliusmarminge avatar Dec 05 '22 19:12 juliusmarminge

Ok. I fixed it https://youtu.be/eCh2G9AQyjs

msasen avatar Dec 06 '22 06:12 msasen

hey thank you, my problem is not @acme/api but @acme/db. after reload my vs code, now its working no error.

lutfi-haslab avatar Jan 02 '23 15:01 lutfi-haslab

hey thank you, my problem is not @acme/api but @acme/db. after reload my vs code, now its working no error.

All i can think off is that you have some global pnpm settings that make this happen

juliusmarminge avatar Jan 02 '23 17:01 juliusmarminge

@juliusmarminge hey julius, did you find any solution? I wanted to use turbo on my main t3 project

violetbee avatar Jan 17 '23 09:01 violetbee