create-t3-app icon indicating copy to clipboard operation
create-t3-app copied to clipboard

bug(docs): breadcrumbs causes layout shifts

Open juliusmarminge opened this issue 2 years ago • 3 comments
trafficstars

Provide environment information

https://create.t3.gg/en/introduction

Describe the bug

https://user-images.githubusercontent.com/51714798/206909715-d33bda93-713a-4fba-ab30-9b04b521bbe6.mp4

To reproduce

Go to https://create.t3.gg/en/introduction

check the breadcrumbs loading after page load.

Additional information

Component: https://github.com/t3-oss/create-t3-app/blob/next/www/src/components/docs/breadCrumbs.tsx

Used: https://github.com/t3-oss/create-t3-app/blob/87f1a43499b6a0d74f8fb09898f6fe0ddd4746c9/www/src/components/docs/pageContent.astro#L23

uses window so prob has to be client loaded? maybe need some rewriting to make it work?

cc @asrvd

juliusmarminge avatar Dec 11 '22 14:12 juliusmarminge

Can tackle #958 at the same time

juliusmarminge avatar Dec 11 '22 14:12 juliusmarminge

@juliusmarminge yes, I couldn't use Astro for the component as ts was giving some weird errors over there, but can be possibly fixed by converting it into an Astro component ? 🤔

about #958 , I don't really understand what's going wrong there, but would look into it

asrvd avatar Dec 11 '22 16:12 asrvd

one thing we can do is ignore everything after # in the link to prevent id from appearing

asrvd avatar Dec 11 '22 16:12 asrvd