create-t3-app
create-t3-app copied to clipboard
t3-oss
docs: accessibility improvements
Partially closes #881
✅ Checklist
- [x] I have followed every step in the contributing guide (updated 2022-10-06).
- [x] The PR title follows the convention we established conventional-commit
- [x] I performed a functional test on my final commit
Changelog
Addressed some points listed in #881
- aria-current for docs navbar
- aria-labels on theme toggle images
- aria-hidden on library card logos as the names are right next to them, prevents double name reading on SR
- Focus outline styling needed on T3 logo in navbar
💯
⚠️ No Changeset found
Latest commit: 7b2b21766e8e8c0ec660efc27cf8d3a0fc6edc36
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| create-t3-app | ✅ Ready (Inspect) | Visit Preview | Nov 28, 2022 at 1:52PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚡️ Lighthouse report for the changes in this PR:
| Category | Score |
|---|---|
| 🟠 Performance | 67 |
| 🟢 Accessibility | 100 |
| 🟢 Best practices | 100 |
| 🟠 SEO | 86 |
| 🟠 PWA | 54 |
Lighthouse ran on https://create-t3-app-git-fork-givensuman-next-t3-oss.vercel.app/
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
would be great if you can work on all the points, we are not in a hurry anyway
Potential overlap with #886.
Haven't reviewed any of them but judging about your descriptions looks like some stuff is implemented in both
would have been better if one single pr has all the points, maybe they can collab ?
would have been better if one single pr has all the points, maybe they can collab ?
Sounds scary and guarantees a bunch of conflicts basically 🥶
In general I don't mind having two PRs for one issue that's as broad as accessibility.
But I agree both people should be aware of each other's work to avoid merge conflict nightmares - either work on a branch together, or at least make sure that both aren't "solving" the same bit in different ways.
