create-t3-app
create-t3-app copied to clipboard
t3-oss
docs: accessibility improvements
Closes(partially) #881
✅ Checklist
- [x] I have followed every step in the contributing guide (updated 2022-10-06).
- [x] The PR title follows the convention we established conventional-commit
- [x] I performed a functional test on my final commit
Changelog
- Focused elements use outline, instead of border, to remove layout shift
- Outline is visible on all focused elements
- Removed unnecessary duplicate
element from the landing page - Tweet carousel is now accessible with keyboard navigation
- Improvements for Screen Readers
check #881 for the full list
💯
⚠️ No Changeset found
Latest commit: 9db7f84655a461a7d9d0f6fe074b32bb0a41cada
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![changeset-bot[bot] avatar](https://avatars.githubusercontent.com/in/28616?v=4 "Published by a pub.dev verified publisher"){kind=small}
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Updated |
|---|---|---|---|
| create-t3-app | ✅ Ready (Inspect) | Visit Preview | Dec 12, 2022 at 2:27PM (UTC) |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
⚡️ Lighthouse report for the changes in this PR:
| Category | Score |
|---|---|
| 🟢 Performance | 100 |
| 🟢 Accessibility | 100 |
| 🟢 Best practices | 100 |
| 🟠 SEO | 86 |
| 🟠 PWA | 54 |
Lighthouse ran on https://create-t3-app-git-fork-ronanru-next-t3-oss.vercel.app/
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Tabbing works great for me in Chrome in Safari but skips a bunch of things in Firefox. Can anyone reproduce this?
Other than that it seems great. The focus selector is very visible and consistent :)
Tabbing works great for me in Chrome in Safari but skips a bunch of things in Firefox. Can anyone reproduce this?
Everything works fine on Firefox for me.
https://share.cleanshot.com/jOD89P
firefox buggy for me too
I tested the Vercel preview on the latest Firefox version on multiple different devices, and it works as expected for me. Maybe it's a bug specific to the macOS version of Firefox. I don't own any Apple hardware, so I can't check this.
I will revert my changes to the tweets slider and technology cards. Hopefully this will fix it, so you can merge this PR.