create-t3-app icon indicating copy to clipboard operation
create-t3-app copied to clipboard

bug: Docs- Mobile pop out menu hidden incorrectly

Open DevMaxC opened this issue 2 years ago • 6 comments

Provide environment information

https://create.t3.gg/ Chrome

Describe the bug

image

When looking at the Docs- if the browser is 767px wide, the mobile nav menu is hidden incorrectly, meaning the button in the top right to expand/hide the menu, appears to do nothing.

To reproduce

Go to- https://create.t3.gg/ Set browser width to 767px Attempt to click the menu button top right

Additional information

No response

DevMaxC avatar Nov 17 '22 14:11 DevMaxC

Im using Chrome and it isn't reproduced🤔. image

JohnBakhmat avatar Nov 17 '22 16:11 JohnBakhmat

I came across the same bug

https://user-images.githubusercontent.com/67912316/202518376-f4d1e4d9-18e2-4cab-a40b-571f0e6440a5.mp4

Can I work on this issue?

KarthikRaju391 avatar Nov 17 '22 17:11 KarthikRaju391

I came across the same bug

https://user-images.githubusercontent.com/67912316/202518376-f4d1e4d9-18e2-4cab-a40b-571f0e6440a5.mp4

Can I work on this issue?

Sure! On mobile so can't assign, but feel free to open a PR

c-ehrlich avatar Nov 17 '22 18:11 c-ehrlich

Hey @c-ehrlich , do I need to create a new branch and edit the code in there or can I just open a PR from the next branch itself?

KarthikRaju391 avatar Nov 18 '22 06:11 KarthikRaju391

Hey @c-ehrlich , do I need to create a new branch and edit the code in there or can I just open a PR from the next branch itself?

Since you need to fork the repo, you can use any branch you want to inside your fork. However I would recommend to create a new one as it makes the workflow easier.

c-ehrlich avatar Nov 18 '22 07:11 c-ehrlich

Hey @c-ehrlich , do I need to create a new branch and edit the code in there or can I just open a PR from the next branch itself?

You can read our contributing guide

nexxeln avatar Nov 18 '22 07:11 nexxeln