create-t3-app
create-t3-app copied to clipboard
chore: bump next to 12.3
Closes #
✅ Checklist
- [ ] I have followed every step in the contributing guide (updated 2022-08-15).
- [ ] The PR title follows the convention we established conventional-commit
- [ ] I performed a functional test on my final commit
Changelog
[Short description of what has changed]
Screenshots
[Screenshots]
💯
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated |
---|---|---|---|
create-t3-app | ✅ Ready (Inspect) | Visit Preview | Sep 8, 2022 at 8:01PM (UTC) |
🦋 Changeset detected
Latest commit: b0765e8b8d58ab60d882877678c568f54a34f54f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
Name | Type |
---|---|
create-t3-app | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
hmm have they changed something in the AppType typedefintion?
yes, seems to be some change in the typedef
./src/pages/_app.tsx:13:16
Type error: Property 'session' does not exist on type '{}'.
11 | const MyApp: AppType = ({
12 | Component,
> 13 | pageProps: { session, ...pageProps },
| ^
14 | }) => {
15 | return (
16 | <SessionProvider session={session}>
yes, seems to be some change in the typedef
./src/pages/_app.tsx:13:16 Type error: Property 'session' does not exist on type '{}'. 11 | const MyApp: AppType = ({ 12 | Component, > 13 | pageProps: { session, ...pageProps }, | ^ 14 | }) => { 15 | return ( 16 | <SessionProvider session={session}>
ill post an issue on their side to see if this is intended
12.2:
export declare type AppInitialProps = {
pageProps: any;
};
export declare type AppPropsType<R extends NextRouter = NextRouter, P = {}> = AppInitialProps & {
Component: NextComponentType<NextPageContext, any, P>;
router: R;
__N_SSG?: boolean;
__N_SSP?: boolean;
__N_RSC?: boolean;
};
12.3:
export declare type AppInitialProps<P = any> = {
pageProps: P;
};
export declare type AppPropsType<R extends NextRouter = NextRouter, P = {}> = AppInitialProps<P> & {
Component: NextComponentType<NextPageContext, any, any>;
router: R;
__N_SSG?: boolean;
__N_SSP?: boolean;
__N_RSC?: boolean;
};
I think it's because {}
is getting passed to AppInitialProps
's pageProps
now
https://github.com/vercel/next.js/issues/40371
this seems like something they'd wanna mention in the release notes...
We'll wait until 12.3.1 is out so we can utilize the new generic AppType<P>
type
continued in #485