create-t3-app icon indicating copy to clipboard operation
create-t3-app copied to clipboard

chore: bump next to 12.3

Open juliusmarminge opened this issue 1 year ago • 9 comments

Closes #

✅ Checklist

  • [ ] I have followed every step in the contributing guide (updated 2022-08-15).
  • [ ] The PR title follows the convention we established conventional-commit
  • [ ] I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

💯

juliusmarminge avatar Sep 08 '22 20:09 juliusmarminge

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
create-t3-app ✅ Ready (Inspect) Visit Preview Sep 8, 2022 at 8:01PM (UTC)

vercel[bot] avatar Sep 08 '22 20:09 vercel[bot]

🦋 Changeset detected

Latest commit: b0765e8b8d58ab60d882877678c568f54a34f54f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 08 '22 20:09 changeset-bot[bot]

hmm have they changed something in the AppType typedefintion?

juliusmarminge avatar Sep 08 '22 20:09 juliusmarminge

yes, seems to be some change in the typedef

./src/pages/_app.tsx:13:16
Type error: Property 'session' does not exist on type '{}'.

  11 | const MyApp: AppType = ({
  12 |   Component,
> 13 |   pageProps: { session, ...pageProps },
     |                ^
  14 | }) => {
  15 |   return (
  16 |     <SessionProvider session={session}>

c-ehrlich avatar Sep 08 '22 20:09 c-ehrlich

yes, seems to be some change in the typedef

./src/pages/_app.tsx:13:16
Type error: Property 'session' does not exist on type '{}'.

  11 | const MyApp: AppType = ({
  12 |   Component,
> 13 |   pageProps: { session, ...pageProps },
     |                ^
  14 | }) => {
  15 |   return (
  16 |     <SessionProvider session={session}>

ill post an issue on their side to see if this is intended

juliusmarminge avatar Sep 08 '22 20:09 juliusmarminge

12.2:

export declare type AppInitialProps = {
    pageProps: any;
};
export declare type AppPropsType<R extends NextRouter = NextRouter, P = {}> = AppInitialProps & {
    Component: NextComponentType<NextPageContext, any, P>;
    router: R;
    __N_SSG?: boolean;
    __N_SSP?: boolean;
    __N_RSC?: boolean;
};

12.3:

export declare type AppInitialProps<P = any> = {
    pageProps: P;
};
export declare type AppPropsType<R extends NextRouter = NextRouter, P = {}> = AppInitialProps<P> & {
    Component: NextComponentType<NextPageContext, any, any>;
    router: R;
    __N_SSG?: boolean;
    __N_SSP?: boolean;
    __N_RSC?: boolean;
};

I think it's because {} is getting passed to AppInitialProps's pageProps now

c-ehrlich avatar Sep 08 '22 20:09 c-ehrlich

https://github.com/vercel/next.js/issues/40371

juliusmarminge avatar Sep 08 '22 20:09 juliusmarminge

this seems like something they'd wanna mention in the release notes...

juliusmarminge avatar Sep 08 '22 20:09 juliusmarminge

We'll wait until 12.3.1 is out so we can utilize the new generic AppType<P> type

juliusmarminge avatar Sep 09 '22 21:09 juliusmarminge

continued in #485

juliusmarminge avatar Sep 20 '22 08:09 juliusmarminge