WinDynamicDesktop icon indicating copy to clipboard operation
WinDynamicDesktop copied to clipboard

3-segment wallpapers doesn't seem to work

Open t1m0thyj opened this issue 2 years ago • 2 comments

Discussed in https://github.com/t1m0thyj/WinDynamicDesktop/discussions/429

Originally posted by ilverogattuso April 11, 2022 I am quite fond of this app, which is why I decided to give it a try and make my own custom themes, that's when I spotted what I think is an error, which is triggered when in the .json you only include 3 out of the 4 Image Lists (in my case I included all and omitted sunrise), afterwards, when selecting the theme from the app, an error will pop-up, so when checking the log it mostly says:

System.IndexOutOfRangeException: Index was outside the bounds of the array.

The current workaround is to include all 4 phases and repeat one image number in the .json, I tried this with sunset and sunrise as well as sunrise and day, and that way it works just fine! Just wanted to know if this happens to anyone else. Anyways love your work sir and thanks in advance!

t1m0thyj avatar May 14 '22 15:05 t1m0thyj

I just ignore the pop-up, then click "Apply". Theme is being applied and working without any issue.

For example this: LoFiGirl theme

wkdk avatar May 14 '22 19:05 wkdk

Confirmed also with the "Adwaita" theme containing day, night and sunset, but no sunrise. The easiest way to avoid this error is to add the missing phase (e. g. sunrise) with the same image number as the opposite phase.

watchmakerful avatar Aug 30 '22 00:08 watchmakerful

The easiest way to avoid this error is to add the missing phase (e. g. sunrise) with the same image number as the opposite phase.

Supporting 3-segment wallpapers is a valid enhancement request but low priority IMO since this workaround exists. If you want to raise more attention to it, please comment or upvote on this issue.

t1m0thyj avatar Jan 03 '23 01:01 t1m0thyj

Added support for 3-segment themes like Adwaita in v5.3.0

t1m0thyj avatar Jun 18 '23 01:06 t1m0thyj