Robots.txt-Parser-Class icon indicating copy to clipboard operation
Robots.txt-Parser-Class copied to clipboard

Parser doesnt work on windows

Open ynizon opened this issue 7 years ago • 4 comments

Hi, thank you for your work. I have detect a bug on windows platform. You can't detect new line in windows, because new line sometime is "\n" and sometime is "\r\n" and not only "\r" (like PHP_EOL). I fix the newLine function to work on both systems. Can you add it to your release please ? More docs here : https://stackoverflow.com/questions/21373478/n-vs-php-eol-vs-br

protected function newLine() { $r = in_array( "\n", array( $this->current_char, $this->current_word ) ); if (!$r){ $r = in_array( PHP_EOL, array( $this->current_char, $this->current_word ) ); } return $r;

}

ynizon avatar Feb 20 '19 15:02 ynizon

Can confirm I was going a bit mad trying to use the parser on a Windows build of Xampp, patched this in and it fixed everything. Merci beaucoup dude :)

genericAnomaly avatar Apr 10 '19 16:04 genericAnomaly

Sorry, not working.Try my fix.

ynizon avatar May 09 '19 13:05 ynizon

and add a namespace like this at the beginning (for use your lib with laravel): namespace Tigor;

ynizon avatar May 09 '19 13:05 ynizon

Hey, guys. I've re-worked the parser a lot lately, but I guess new lines might still be an issue. Will take a look soon.

P.S. Namespaces are already there, but not released to packagist. You can take a look on master branch.

t1gor avatar Oct 19 '21 16:10 t1gor