fingertip icon indicating copy to clipboard operation
fingertip copied to clipboard

reboot: Add a simple plugin to reboot a machine

Open neverpanic opened this issue 1 year ago • 1 comments

Assumes systemd, beacuse it uses systemctl to wait for the boot to complete.

neverpanic avatar Jul 19 '24 12:07 neverpanic

reboot: Add a simple plugin to reboot a machine

Good idea, this is a common scenario.

Assumes systemd, beacuse it uses systemctl to wait for the boot to complete.

Yeah, since this the step is distro-specific, this should be made more flexible with hooks. See, for example, how timesync decouples this.

t184256 avatar Jul 19 '24 12:07 t184256

Untested with os.alpine, because that seems to be broken. Also, os.alpine does not define m.login(), so the reboot action is also broken because of that. I may eventually fix the os.alpine definition, but quite a few things seem to have changed in alpine land, so it isn't trivial.

neverpanic avatar Aug 28 '24 18:08 neverpanic

Thank you, doubly so for patience with my review.

t184256 avatar Aug 30 '24 13:08 t184256