Sam Clarke-Green

Results 40 comments of Sam Clarke-Green

This probably feeds into #366

Suggested this as a good issue for @cameronbateman-mo

I have addressed the comments from the previous reviews, the CI tests pass, and I've successfully used my branch to build skeleton in LFRic core using Jason's branch, so I...

MPI is now supported as a wrapper, but other work is still outstanding.

Adding a note to remind myself to check whether fab is reporting that it is recompiling items when all it is doing is calling a tool.

I've traced the misleading compilation messages to this section of the `compile_pass()` function in `compile_fortran.py`: ```py # what can we compile next? compile_next = get_compile_next(compiled, uncompiled) # compile logger.info(f"\ncompiling {len(compile_next)}...

UMDP3 coding standards state that modules should not be used twice (presumably actually more than once?): > For code portability, be careful not to `USE ` twice in a routine...

Top level issue for other logging tickets.

The current fcm-based UM warning checker processes the entire compiler output log. When run against a branch, it restricts itself to reporting problems in the files updated in the branch....

This is not currently high priority because we do not believe that anyone is using static linking at present.