Taiga KATAYAMA

Results 33 comments of Taiga KATAYAMA

Do you mean to keep test code despite that they are not executed for the revision of source code? I want to keep only valid/maintained tests ("valid/maintained" means that we...

Judging whether we keep tests or not requires an effort. We simply keep only tests of supporting pg version. (Seen from one FDW, its may be a small effort. But...

Thank you for your understanding.

@mkgrgis Thank you for your proposal. We would appreciate it if you could carry out the following in order of priority. 1. tested RETURNING implementation 2. tested attached schemas with...

@lamdn1409 Could you review #107 ?

@mkgrgis I'm sorry for the late reply. > Will 2->1->3 order of reviews good for pgspider team? Could you share your opinion? It's okay for us. If 1 is not...

@mkgrgis Thank you for your effort. Yes, @lamdn1409 will check #109.

Thank you for reporting. SQLite FDW expects/assumes that column type of foreign table and data affinity of SQLite are same, as you know. It is not supported to map different...

> what about https://github.com/mkgrgis/sqlite_fdw/tree/readme-fix-and-additions#datatypes ? @mkgrgis Thank you for summarizing it. Please give us a time to confirm it. > Could you point me a line to add col IS...

> I thinks it's a bad example. Neither for '' nor for NULL there will no true condition predicate. Empty strings are equal '' = '', but one NULL isn't...