t-cordonnier

Results 42 comments of t-cordonnier

> Now breaks the feature. > > > Now produces without property Yes that is the reason of my point 2: the test works with default translations, if you want...

This part is a draft, I don't know when I would eventually come back to it. Part 1 is already merged, see #185

@miurahr didn't I tell you that I was working on something similar when we discussed https://github.com/omegat-org/omegat/pull/805? Can't we try to coordinate to avoid doing same thing at same time? I...

> A editor and core change can break all the features in OmegaT, we should be careful and need to discuss a direction , and also requires thorough review process....

@miurahr Since I was working on something similar for Manuel Suto Pico, I asked him to test both your version and mine. Such a feature must be strongly tested because...

> Could you explain why stax filter behavior is changed and OpenXML filter and XLIFF filter become broken? My first impression is that there is a moment where the filter...

> @t-cordonnier Stax filter become broken when jackson XML bind enabled. Could you explain why stax filter behavior is changed and OpenXML filter and XLIFF filter become broken? > Hi...

> Test failed; org.omegat.filters4.Xliff2FilterTest.testKey(Xliff2FilterTest.java:65) Yes, the patch I propose does also correct this.

> @t-cordonnier I believe I can integrate your #24 change into [980bc62](https://github.com/omegat-org/omegat/pull/239/commits/980bc627726ff74f5732fae703a0cddc215c5509) and [3ebf2e3](https://github.com/omegat-org/omegat/commit/3ebf2e3b31c7097ddcbc92bd38f69877267632e0) . Could you check it works? Hi Hiroshi I wanted to alert you about the fact...

Ok, this is #538 Once you can push it to master, you can do the chaanges about SRX in #239, but only the part about migration from JAXB to Jackson,...