t-cordonnier
t-cordonnier
I am 100% in favour of removing any dependency to JAXB: it is slow and highly memory consuming, and not anymore present in standard JRE after Java >= 9 But...
> @t-cordonnier Thank you for head me up to GlossaryReaderTBX class. Good that you finally found my code using StaX. This should be a significant improvement when loading very big...
> @t-cordonnier Thank you for head me up to GlossaryReaderTBX class. You should have a look to org.omegat.core.segmentation.SRX class : this one also uses JAXB and should be migrated to...
> There is no TAAS related test case in the project. Does anyone help testing TAAS? TAAS is a server, that is not so easy to test code related to...
Sorry for the delay, I was in holidays and did not see that I had received this request for review. First about the feature itself: exactly as @miurahr I would...
> Freelancers commonly work with different clients and need per-project settings for such data, > If I want to be able to decide which TMs are exported for a job...
In the RFE I agree more with what you wrote here: https://sourceforge.net/p/omegat/feature-requests/1578/#9e5d See ExternalTMFactory, line 140: ` if (sourceLang.equals(new Language(tuvTarget2.lang))) { ` Here if sourceLang = "en" and tuvTarget2.lang =...
> how would this work if the project had sourceLang="en" and then there were several tuv elements with languages, say, en-US and en-GB (but none with just en). Would all...
> @t-cordonnier how do you handle a mandatory attribute `srclang` of `` in TMX file? I think a source language of TMX file is defined in header. Isn't it? This...
> Current logic in ExternalTMXFactory is >` > if (sourceLang.equals(new Language(tuvTarget2.lang))) { > continue; > } > ` > > A root cause may be here, boolean `new Language("en").equals(new Language("en-US"))`...