Thomas Braun
Thomas Braun
@bendichter What is your desired data type in HDF5 terms?
@oruebel Thanks for the explanation. I think supporting a new string datatype which is ASCII-only is not the right direction.
> However, we recently changed the epoch (re)creation to be sample exact. With the upper approach we would get a mix of old non-sample exact epochs and "new" sample exact...
Not a review just some drive-by-comments: - ED_InsertPostProcessRow should work more like ED_AddEntriesToLabnotebook. This would give the same speed benefits (writing all entries in one go) but alleviate the caller...
I've reapplied the ipt formatting and linting changes. But don't know howto fix the merge conflict.
Does that also resolve the #881? Review: 59c47e742 (DAP: Change comment getter for user comment to retrieve string directly from control, 2025-04-02) Jeep. 5c982a337 (LBN: Do labnotebook upgrade on most...
@MichaelHuth Did you see my review in https://github.com/AllenInstitute/MIES/pull/2385#issuecomment-2787486825?
Review: 59c47e742 (DAP: Change comment getter for user comment to retrieve string directly from control, 2025-04-02) Good. f9ab329da (LBN: Do labnotebook upgrade on most common MIES entry points, 2025-04-02) Nice!...
> @t-b I added LBN capabilities. However, I am not sure if it makes sense to just consider it when inserting. Because if one adds a new entry it will...
Note to self: Check that the function that creates empty recreated epochs returns `$""` for no epoch info.