Thomas Weißschuh
Thomas Weißschuh
@transamericamoon I am not sure this is the issue. The linked issue was about in-flight requests at the point in time the client is closed. All requests in sonar-stash are...
You can also try to update async-httpclient to the latest version.
Which version of sonarqube/stash/sonar-stash are you using?
It is reported in the sonar-scanner output. Is your project multi-module?
Then you should probably look at the `sonar.stash.repository.root` setting. Also if this is a POC, beginning with a single-module project would probably be easier. FYI sonar-stash will stop working as...
It should be set to the root of the repository for multi-module projects. It most probably is "$PWD". For testing you can also spin up a local SQ instance easily.
Hi @tommywo, thanks for this! Can you remove remove the three irrelevant commits from your PR?
@tommywo I still have a few minor nit-picks. A setting to switch between the current behaviour and the new stuff is probably the right way forward.
@tommywo Thanks! Please squash the commits into one. As approving/un-approving and approving/"needs work" are mutually exclusive I propose to merge the setting into `sonar.stash.reviewer.approval`. We could have a special value...
To be honest I would prefer not introduce a deprecation warning and force users to change their working configuration. Should we release a incompatible version 2.0 in the future we...