c-pchart
c-pchart copied to clipboard
scaleComputeY may return an array, when integer is required
There are multiple places when the result of scaleComputeY
is used as parameters of function, that expect integers. This may yield unexpected results or errors.
in my branch I solved it by separating the functions for single input and for array in that way I was able to verify both input and output
So you would change the interface of classes. This would require me to start a new version, 4.x
, that would not provide 100% BC, but I think it can do that leap. Let us push as many of your non-BC breaking fixes to the current master
branch, then I will make a 3.x
branch out of it and we can start doing things that will break BC.
scaleComputeY is an internal function. changing it would not break compatibility