c-pchart icon indicating copy to clipboard operation
c-pchart copied to clipboard

scaleComputeY may return an array, when integer is required

Open szymach opened this issue 7 years ago • 3 comments

There are multiple places when the result of scaleComputeY is used as parameters of function, that expect integers. This may yield unexpected results or errors.

szymach avatar Mar 08 '17 22:03 szymach

in my branch I solved it by separating the functions for single input and for array in that way I was able to verify both input and output

bozhinov avatar Dec 27 '17 20:12 bozhinov

So you would change the interface of classes. This would require me to start a new version, 4.x, that would not provide 100% BC, but I think it can do that leap. Let us push as many of your non-BC breaking fixes to the current master branch, then I will make a 3.x branch out of it and we can start doing things that will break BC.

szymach avatar Dec 27 '17 23:12 szymach

scaleComputeY is an internal function. changing it would not break compatibility

bozhinov avatar Dec 28 '17 07:12 bozhinov