Szehon Ho
Szehon Ho
I guess they initially made rewriteManifest as a safe API. I wonder, does DeleteFiles API achieve this? The next commit will remove that manifest if all its contents are removed....
btw, did you look at that case? I didnt follow but from #8599 supoosedly it only happens when its instance of CleanableException
Sounds good. Im thinking adding deleteManifest method there is better, then. > I tried to leverage delete by file path in [DeleteFiles](https://github.com/apache/iceberg/blob/main/api/src/main/java/org/apache/iceberg/DeleteFiles.java#L45) ->[MergingSnapshotProducer](https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L187-L202) but it does not work. Is it...
Well, that was my thought as its parallel with appendManifest. But now I see https://github.com/apache/iceberg/pull/10396 try to deprecate that, so like to get @Fokko thought here. I think appendManifest/ deleteManifest...
Thanks @Fokko !
Oh, I did not see this issue. That was to fix the 1k schema id colliding with partition id problem in the schema map, it looks like a bug. Im...