Sung Yoon Whang comments

Results 71 comments of


                                            Sung Yoon Whang

Private Provides

Actually, the signature of `Provide` is an `interface{}`. @hbdf You could add this using a functional option then. ``` fx.Module("myModule", fx.Provide( NewTypeA, fx.Private(true), ), ) ``` where: ```go func Private(isPrivate...

Ability to check if the error belongs to dig

cc @tchung1118 @jacoboaks

fx.OnStart, fx.OnStop doesn't work with named dependencies (using fx.ResultTags)

Thanks for reporting this issue. We'll look into this issue shortly. Internal Ref: GO-1661. cc @tchung1118

Getting level from zap logger

[v1.23.0](https://github.com/uber-go/zap/releases/tag/v1.23.0) contains this feature - closing this as done!

It would be nice if an app could pass the causing error to Shutdowner

This is a reasonable feature request. I'll start tracking it in our backlog :) Thanks for the suggestion.

Support for soft RAM limit?

hey folks, we've internally developed a system that automatically detects and sets GOMEMLIMIT and decided to not put that code on automaxprocs. The main rationale behind that decision is because...

Add an option to override stacktrace collection logic

@FlorianLoch nope, the issue is still a valid ask and we welcome PRs!

Child scope of container is not visualized on dot graph

This is a valid feature request. I believe the DOT representation wasn't rewritten when we rewrote Dig's internal graph representation when we worked on the Scope feature.

Child scope of container is not visualized on dot graph

I'll leave this open for now since we need some more visual improvements. Thanks

Support app shutdown with exit codes

This has been completed with https://github.com/uber-go/fx/pull/989.