Takuya ASADA

Results 121 comments of Takuya ASADA

Replaced read_command to nullptr.

Do std::move() key and data into write_strings_cas_request.

Stop std::move(request) to a different shard, create request at the destination shard instead.

Stop returning bool from write_strings().

Add "seastar::" prefix to smp_service_group, drop including seastarx.hh.

> I have a more general note: I see you decided not to add CAS as an optional "isolation mode", but as the only, mandatory, mode - every write will...

@nyh I think I addressed all, please review it again. Also I added reply for each comments.

Rewrited the code since `self.__fmt(val).format(key, value)` was looks strange code, so I dropped it and replaced by `__format_line(self, key, val)` to return correctly formatted "{key}={val}" string. Also I found that...

Verified not quoted value and quote value works as expected, on following test code. Also tested escaping double quote worked as expected. I will add the test code into #10809....