sphil icon indicating copy to clipboard operation
sphil copied to clipboard

Create a modal for "edit this page on Github"

Open Firgrep opened this issue 1 year ago • 4 comments

New users people to github might be overwhelmed by it, so we want to make sure that support is visible.

The "edit this page on Github" in the table of contents on the right panel should open a modal that gives the option to continue to github or go to the contributions page to learn about what Github is and how to use it.

We'll probably need to turn off the default link in Nextra from the theme config and build our custom component based off of their solution, except that it opens the modal instead of directly linking. Nextra exposes a useConfig hook, if I recall correctly, which should expose the dynamic github link.

Firgrep avatar Sep 26 '24 18:09 Firgrep

If you would like to assign me to this issue, my ongoing PR can be associated 😊

PatrickLarocque avatar Sep 30 '24 22:09 PatrickLarocque

Pat's got busy, so if anyone else wants to pick this up! Just make a comment :)

Firgrep avatar Nov 17 '24 09:11 Firgrep

@Firgrep I'll take it! :)

JMielbrecht avatar Dec 02 '24 16:12 JMielbrecht

@JMielbrecht MUI has a really nice Dialog component you could use for the modal functionality

Firgrep avatar Dec 02 '24 17:12 Firgrep