si icon indicating copy to clipboard operation
si copied to clipboard

chore(edda,web): Remove Secret specific MVs and include necessary data alongside props/attributes

Open britmyerss opened this issue 7 months ago • 1 comments

The secrets subsystem originally was designed to manage and create secrets separately from components. The original Secret MVs were designed to support this, but given secrets will now map 1:1 with components, we no longer need any of these independent MVs or lists of secrets/secret definitions.

This PR makes that change, along with a few front end fixes alongside:

  1. Components Details will now display all secret props (previously it was only showing one)
  2. If the prop is the secret definition, show the form to create/replace the secret
  3. If the prop is not secret defining, allow the user to create a prop to prop connection and use an existing secret.
  4. For Possible Connections, we don't want to show the attributeValue.value for secrets, as it's just the SecretId. Instead, grab the name of the secret.
  5. Add description to the Secret Form

Todos:

  1. Ability to remove a connection for a secret prop
  2. We likely need a custom AttributeInput.vue component for interacting with secret props
  3. Account for secrets correctly in the Possible Connections calculation (right now it'll show all string props as available, which is not what we want, but this can be improved outside of this PR)
  4. Styling!
  5. Show name + description for a secret (but not the encrypted values).

britmyerss avatar May 30 '25 00:05 britmyerss

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

github-actions[bot] avatar May 30 '25 00:05 github-actions[bot]