si icon indicating copy to clipboard operation
si copied to clipboard

chore(firecracker): re-enable vsock telemetry forwarding

Open fnichol opened this issue 9 months ago • 2 comments

This change re-enables the stream forwarder in Cyclone and the listener in Veritech, both of which help are used to forward OpenTelemetry data out of a Firecracker VM.

Prior to disabling these tasks, it was unclear whether the spawned tokio tasks would naturally terminate on their own, or whether they would continue to run even as more Firecracker instances were spawing in Pool Noodle's pool. This change attempts to tie the lifetime of these forwarding tasks to the lifetime of the Firecracker instance (that is the termination of the VM should also trigger the shutdown of the forwarding task).

fnichol avatar Mar 20 '25 22:03 fnichol

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

github-actions[bot] avatar Mar 20 '25 22:03 github-actions[bot]

This may need a careful load test as it re-enables listener sockets on Veritech. Should be fine now, but worthy of a confirmation under load.

Note: I'm not 100% convinced that copy_bidirectional will always do the right thing but am hedging this with a cancel-able task now (i.e. that task can be pre-empted and cancelled).

fnichol avatar Mar 20 '25 22:03 fnichol