potlatch2 icon indicating copy to clipboard operation
potlatch2 copied to clipboard

Use JOSM Imagery Sources

Open grischard opened this issue 5 years ago • 7 comments

grischard avatar Apr 03 '20 09:04 grischard

Thanks! I'll need to test this - Flash uses its own antique CORS-like method called crossdomain.xml, and although there is already a crossdomain.xml present on josm.openstreetmap.de, the whole thing is sufficiently arcane that I wouldn't be happy merging without testing. Once I've done that I'll merge this.

systemed avatar Apr 03 '20 10:04 systemed

I'm afraid this isn't mergeable as it stands, because https://josm.openstreetmap.de/crossdomain.xml only permits Flash to access resources on josm.openstreetmap.de if the SWF was loaded from an HTTPS page.

Although that wouldn't be a problem for openstreetmap.org, localhost (and aliases) are generally not HTTPS. In other words, this makes it impossible to develop P2 locally and show imagery, which means I don't know whether this patch would actually work or not. :)

If the JOSM folks add secure="false" attribute to the allow-access-from-domain element (cf http://osmlab.github.io/crossdomain.xml) then I believe this might work.

systemed avatar May 08 '20 20:05 systemed

Gah.

Could testing on errol, maybe with a bit of sshfs, work?

grischard avatar May 09 '20 00:05 grischard

It could, but that would remove the ability to develop P2 locally, and require setting up a Flex toolchain on errol. JOSM adding 15 characters to one file on their server would be a lot easier.

systemed avatar May 09 '20 09:05 systemed

@systemed use localhost with a self-signed certificate.

Random selected guide: https://stackoverflow.com/questions/8169999/how-can-i-create-a-self-signed-cert-for-localhost

Firefishy avatar May 27 '20 10:05 Firefishy

I think it's probably just easiest to mirror the JOSM file on systemed.net.

systemed avatar May 27 '20 11:05 systemed

I've mirrored the josm json at https://stereo.dev.openstreetmap.org/maps-potlatch.json with the right https://stereo.dev.openstreetmap.org/crossdomain.xml

grischard avatar Jun 07 '20 20:06 grischard