systemd icon indicating copy to clipboard operation
systemd copied to clipboard

Published 20 hours ago • verified publisher icon systemd

Revert "Implement DNS notifications from systemd-resolved using varlink"

Open poettering opened this issue 2 years ago • 3 comments

This will become API, and I think we need an iteration or two more before this is ready to be that. Please see my (admittedly late, soryy) review comments on #22845.

Reverts systemd/systemd#22845

poettering avatar Sep 09 '22 12:09 poettering

Can't it just be fixed up? That PR has been open with back and forth for half a year...

bluca avatar Sep 09 '22 12:09 bluca

Well, sure, but it's a lot to fix. If a patch is quickly prepared to fix the points I raised, we could merge that instead of this.

poettering avatar Sep 09 '22 12:09 poettering

Please also revert PR #24637 if this is going to be merged instead of fixing the original PR.

yuwata avatar Sep 11 '22 16:09 yuwata

Trying to fix up based on your comments instead: https://github.com/systemd/systemd/pull/24823

bluca avatar Sep 26 '22 14:09 bluca

Let's close this one in favour of the already commited #24823 and #24853 that i just posted.

poettering avatar Sep 28 '22 20:09 poettering