Paul Donald
Paul Donald
Looks largely OK - although my p910nd rewrite seemed to acquire jow as a maintainer. Logic? Not against it - just want to understand the decision making here. LICENSE changes...
Wow, micro-optimisations! Yeah, I ran `reset ; prometheus-node-exporter-ucode thermal` alot. Very helpful aspect :) > - creating metrics of the same name should always happen once in the main scope,...
> @systemcrash like I said before, I'm not married to the exact number. That one was the only thing in the official guidelines, so that's what I went with. If...
@dhewg if you could take another look? I optimised netdev and netclass for ordered output.
pinging @dhewg - think I've addressed everything here.
> For hwmon, Is this the expected `chip`? `node_hwmon_chip_names{chip="thermal_thermal_zone0",chip_name="cpu_thermal"} 1` Yes, that looks correct. It pulls the chip_name from: ``` ls -l /sys/class/hwmon/hwmon0/ ... -r--r--r-- 1 root root 4096 Dec...
OK. It's an extra now. Much appreciated if you could take hwmon for another spin @dhewg
ping @dhewg for final test run
> Don't get me wrong, it may as well be! I just don't know and don't have the time to dig in atm. (my) Reasoning being that we [output ordered](https://github.com/openwrt/packages/pull/28016#issuecomment-3617226382),...
> > (my) Reasoning being that we [output ordered](https://github.com/openwrt/packages/pull/28016#issuecomment-3617226382), rather than revisiting the same metrics for different devices. It makes stare and compare in the scrape output clearer, among other...