Paul Donald

Results 964 comments of Paul Donald

@jempatel looks like you missed the 15m -> 15h thing I flagged in the review.

> @galeksandrp - the description text needs to be polished for better english and the option dependencies are not correct, the `ppsk: "1"` dependency on the RADIUS options looks wrong,...

OK, could you please update your commit message to how I've edited [your first message above](https://github.com/openwrt/luci/pull/4513#issue-719479806)?

> I'll be updating the description and review again the dependencies/ permutations. Regarding to "Yeah, not sure I get the ppsk: 1 parts. Are you saying that e.g. to use...

> @systemcrash I have updated the commit message of the PR. Could you fix the following in your commit message please? It makes searching in git more consistent. dinamically ->...

Closed via 75a2fd233baabf6fa5bafcb13ccc6d7000a4604d

@mgiganto simply mandating `ppsk: '1'` is not correct. jow- wrote: `the ppsk: "1" dependency on the RADIUS options looks wrong, those options should be available even if ppsk is not...

Further, please update your commit message [as I specified here](https://github.com/openwrt/luci/pull/4513#issuecomment-1913612768)