Paul Donald
Paul Donald
Agreed on the consolidation idea. But that can be another PR. Looks OK @mrunge
Looks OK @mrunge
> IMHO, it would be more useful to have the metric name changed for the cooling device from `gauge` to `state` or `cooling_state`, to reflect the stat being exposed by...
The linked issue above mentions: > * If possible, try to find a _Prometheus exporter_ reporting the same metric(s) and use the same naming schema. > * Update the _ethstat...
I would guess that that PR targets 6, and has been converted to v6 code.
Largely looks OK - have these changes been tested in operation? Also, is it much more work to: > * rename **Metric** block to **Result** to avoid confusion with _Metric_...
Seems fit for purpose. Can you fix the CI errors?: - clang-format — Please run: contrib/format.sh src/dpdk_telemetry.c src/dpdkstat.c src/logparser.c src/mcelog.c src/nut.c src/openvpn.c src/pcie_errors.c sr… -
I guess just run ` Please run: contrib/format.sh src/dpdk_telemetry.c src/intel_pmu.c src/intel_rdt.c...` like it asks. Take it from there.
> Running the Web service doesn't (easily) work fpr me. I do have clang-format installed plus the project provides a .clang-format file. The project's CI should be consistent with the...
Innocent question: but have these improvements been tested in action?