ec icon indicating copy to clipboard operation
ec copied to clipboard

Actually disable lemp9 power button when off, AC disconnected, and lid closed

Open jackpot51 opened this issue 5 years ago • 5 comments

This feature is currently only preventing power button presses when suspended, not when off.

jackpot51 avatar Jul 22 '20 14:07 jackpot51

Isn't the power button handled in the common board code? Is this a problem with any other system?

RemingtonHolder avatar Dec 30 '20 16:12 RemingtonHolder

This should be handled in the common board code here. https://github.com/system76/ec/blob/42f1b4863fe5c41c76870acf4436ec3f349ae9be/src/board/system76/common/power.c#L393-L399

RemingtonHolder avatar Dec 30 '20 16:12 RemingtonHolder

There is some glitching due to the electrical design. This commit takes care of that:

https://github.com/system76/ec/pull/121/commits/954082178a093e46b62e7889747b42671801a6d0

jackpot51 avatar Dec 30 '20 22:12 jackpot51

@jackpot51 Is this a persisting issue with lemp10?

RemingtonHolder avatar Dec 30 '20 23:12 RemingtonHolder

lemp10 has the above firmware fix applied

jackpot51 avatar Jan 01 '21 14:01 jackpot51