ec icon indicating copy to clipboard operation
ec copied to clipboard

Published 20 hours ago • verified publisher icon system76

Allow controlling debug via `config.mk`

Open crawfxrd opened this issue 1 year ago • 2 comments

Add new Makefile configs for controlling the log level and mechanisms instead of having to modify the CFLAGS directly.

Allows adding values to top level config.mk instead of the nested common.mk file.

crawfxrd avatar Dec 26 '23 19:12 crawfxrd

I'm not seeing a config.mk in the top level. Would a user be expected to generate their own if they want to use this new option?

leviport avatar Dec 28 '23 23:12 leviport

Yes, the same way that BOARD or KEYMAP can be set. It can also be set in ec.config in firmware-open. This way I can just have a commented out config value and uncomment it when I want to enable logging, such as is done with coreboot and edk2.

crawfxrd avatar Dec 28 '23 23:12 crawfxrd