ec icon indicating copy to clipboard operation
ec copied to clipboard

power: Do not reset KBLED state on CPU wake

Open crawfxrd opened this issue 2 years ago • 4 comments

Do not reset the keyboard backlight on CPU wake. This fixes keyboard backlight turning off and becoming white on wake from sleep.

TODO: Fix for all kbled mechanisms.

crawfxrd avatar Mar 27 '23 20:03 crawfxrd

Arguably, a function called "reset" should put the backlight level and color in a known state.

But what do bonw14, darp5, and oryp5 actually need to do for I2C when waking the CPU? Does kbled_reset need to be called at all?

crawfxrd avatar Mar 28 '23 18:03 crawfxrd

In my tinkering this appeares to break the system76-acpi-dkms module, making the LEDs unusable with the hardware controls inside Linux. If you remove the module they begin to work again.

ilikenwf avatar Sep 11 '23 22:09 ilikenwf

I may have spoken too soon... if I was wrong, I'll post about it again here...but seems my distro is not using the master branch.

ilikenwf avatar Sep 11 '23 22:09 ilikenwf

So it does not appear to be this commit, however the current master does seem to break things with the keyboard backlight controls when the acpi module is in use.

ilikenwf avatar Sep 11 '23 23:09 ilikenwf