darp7: Can power on when unplugged, lid closed

[crawfxrd]

Steps to reproduce:

1. Power off machine
2. Unplug AC adapter
3. Close lid
4. Repeatedly press the power button

Expected behavior

The machine does not turn on.

Actual behavior

The machine occasionally boots.

Notes

Tested on:

• ff53939

LID_SW# may be high early in the boot, causing the check to disable the power button to fail. In some cases, lid_event() reports "Lid open" (and thus updates lid_state, meaning it is also not reliable).

[16:06:24] ESGCTRL2: 0 set to 40
[16:06:24] PLLFREQ is 0x01
[16:06:24] PLLFREQ is now 0x07
[16:06:24] ESGCTRL2: 40 set to 0
[16:06:24] ESGCAC2: A set to B

[16:06:24] System76 EC board 'system76/darp7', version '2021-08-02_99af8a3-dirty'
[16:06:24] 00: power_on_ds5
[16:06:24] POWER_STATE_DS5
[16:06:24] 00: SLP_SUS# asserted
[16:06:24] Lid open

[jacobgkau]

This is still an issue in 2022-11-02_4718ec4 currently being tested (it's not a regression, just noting for the record.)

[jacobgkau]

This is still happening on 2023-08-18_a8dd6c2. Also, even with 2022-11-02_4718ec4, it doesn't seem to depend on the AC adapter being plugged in when the machine was last powered off anymore.