docs icon indicating copy to clipboard operation
docs copied to clipboard

Update laptop-battery-thresholds.md

Open zazesty opened this issue 3 months ago • 3 comments

Persistent battery charging thresholds were added to 2025-07-24 Open Firmware by writing to EC flash.
I edited this article to reflect this, reworking a paragraph to inform folks with new firmware that they may change charge thresholds in a persistent manner via the terminal (obviating systemd), and guiding folks using older firmware to the systemd procedure.
my first pull request, please let me know if i should do something differently. Thank y'all!

zazesty avatar Oct 13 '25 03:10 zazesty

I think some changes are not necessary: changing This feature is not currently finished. to This feature is not fully finished. does not make things clear. It is either finished or it is not, adding fully finished does not make sense.

We are updating firmware often, so I feel it might be better to not explicitly name the firmware version 2025-07-24_c242738 would become outdated.

garrettjwilke avatar Oct 13 '25 17:10 garrettjwilke

Yeah, that’s personal preference/style, not necessary to change. -ZavdiOn Oct 13, 2025, at 10:15 AM, garrettjwilke @.***> wrote:garrettjwilke left a comment (system76/docs#1316) I think some changes are not necessary: changing This feature is not currently finished. to This feature is not fully finished. does not make things clear. It is either finished or it is not, adding fully finished does not make sense. We are updating firmware often, so I feel it might be better to not explicitly name the firmware version 2025-07-24_c242738 would become outdated.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

zazesty avatar Oct 13 '25 19:10 zazesty

I went ahead and simplified this. The note isn't really needed at the top anymore now that the feature's fully implemented in firmware. We can just mention where the workaround's needed in its own section. The GUI can be added to the article once it's implemented.

jacobgkau avatar Oct 13 '25 22:10 jacobgkau