Order of commands when updating firmware from Live Disk leads to failure

[duelafn]

Hello, I've just updated my firmware and the command order in "Updating on Other Operating Systems" in content/system-firmware.md leads to an unnecessary error.

What I did

As suggested in the docs:

sudo apt update
sudo apt install system76-driver system76-firmware
sudo mkdir -p /boot/efi
sudo mount /dev/nvme0n1p1 /boot/efi
gnome-control-center firmware

What happened

The firmaware tab show no updates available

What I expected to happened

New firmware updates available to install

What went wrong

When system76-firmware is installed it starts system76-firmware-daemon.service which immediately fails because /boot/efi does not (yet) exist. The service just fails.

How I fixed it

I restarted system76-firmware-daemon.service via,

systemctl restart system76-firmware-daemon.service

After restarting the service, the firmware updates were available in the gnome-control-center firmware tab.

How to fix in docs

I suspect that adjusting the command order in both "For NVMe Drives" and "For SATA Drives" to mount the EFI partition before installing the firmware package would address the issue without resorting to restarting the service – sorry I didn't get a chance to test to verify (e.g., for NVMe):

sudo mkdir -p /boot/efi
sudo mount /dev/nvme0n1p1 /boot/efi
sudo apt update
sudo apt install system76-driver system76-firmware
gnome-control-center firmware

Possible bug in system76-firmware-daemon?

It may also be considered a bug in system76-firmware-daemon that the service crashes when /boot/efi is not present, but I leave it to System76 internally to decide.

Thanks!