theme-ui icon indicating copy to clipboard operation
theme-ui copied to clipboard

theme styles generate duplication css output

Open zhaohuanyuu opened this issue 3 years ago • 5 comments

Describe the bug When I want to use the styles attribute to customize the native html tag style, for example: blockquote, but the style that ends up being generated to the page is repeated twice

To Reproduce

  1. clone my reproduction project blog production
  2. yarn install & yarn start
  3. Click the Blog header
  4. Route to the named reproduction article
  5. Inspect text content is "this is theme-ui style custom style" element

Expected behavior

I don't know why generate duplication css output,that should generate css only once

Screenshots image

image

Additional context As long as the styles defined from the styles object of theme-ui config have the problem of generating duplicate css

zhaohuanyuu avatar Oct 23 '22 12:10 zhaohuanyuu

Yep, I'm having this issue too on sites like https://lachlanjc.com/ — not sure what's going on

lachlanjc avatar Nov 17 '22 20:11 lachlanjc

I don't see this problem in a commercial project nor in CodeSandbox.

Also, not all classes in @lachlanjc's websites have duplicate styles.

image

Do you guys think we can narrow this? When does it happen? When does it not happen?

hasparus avatar Nov 18 '22 10:11 hasparus

I can confirm that duplication takes place in some undisclosed cases. It's not clear at the moment what causes this behavior.

Screenshot 2023-02-14 at 18 52 33

mbektimirov avatar Feb 14 '23 14:02 mbektimirov

@hasparus wondering if there are any updates for this issue. I am still able to see this duplicate style issue on my new Gatsby project. Using the gatsby-plugin-theme-ui plugin.

simeng-li avatar Apr 11 '23 09:04 simeng-li

I don't see this problem in a commercial project nor in CodeSandbox.

Also, not all classes in @lachlanjc's websites have duplicate styles.

image

Do you guys think we can narrow this? When does it happen? When does it not happen?

@hasparus The problem appears to be specific to Gatsby and changes introduced in the Head API in Gastby 5.6. See Gatsby #38249 for more details and repros at:

  1. https://github.com/techfg/gatsby-duplicate-styles-when-using-head-api.git
  2. https://codesandbox.io/p/sandbox/duplicate-style-element-in-head-when-using-head-api-and-theme-ui-h8zqtk

techfg avatar Jun 16 '23 11:06 techfg