theme-ui icon indicating copy to clipboard operation
theme-ui copied to clipboard

Custom SVGs for Radio & Checkbox components

Open MuhammadJamaluddin opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe. I don't think Theme UI should be opinionated on which SVGs should be used for the Radio & CheckBox components

Describe the solution you'd like Probably an additional prop called customIcon maybe... based on which we could conditionally render the passed SVG icon otherwise we use the default icons?

Describe alternatives you've considered The alternative is obviously to rebuild the component from the ground up, but it's really counterproductive given that Theme UI have the component & API in place

Additional context Theme UI should make it seamless to build a design system & enforcing a specific icon without giving the option to override it sounds a bit counterintuitive for me

MuhammadJamaluddin avatar Nov 15 '21 13:11 MuhammadJamaluddin

Actually, thinking about it, it probably has to be customIcons (an array), where we pass two SVGs, one for checked state & another one for the unchecked state

MuhammadJamaluddin avatar Nov 15 '21 17:11 MuhammadJamaluddin

any updates on it?

sikhaman avatar Apr 27 '23 14:04 sikhaman

@sikhaman It's not planed in foreseeable future, sorry. You can copy the Checkbox component into your codebase and change the icons there.

hasparus avatar Apr 27 '23 19:04 hasparus