Matthew Finkel

Results 15 comments of Matthew Finkel

While not directly appropriate for this PR, we should think about adding a similar check as part of response blocking, as well. I'm thinking about some proxying protocols where DNS...

> Any reason for this choice? The current motivation is 1) json is easily readable/understandable (as you've noted), 2) generating C++ gives us compile-time checks that the content of the...

> I don't care for the direction this patch has taken. The goal of our data-driven quirk tool would be to modify a JSON file, and (without rebuilding) have WebKit...

> It doesn't allow us to configure user agent quirks without recompiling, and it also doesn't even replace our existing quirks. It does, this PR allows for modifying the json...

I might need to go back to building the user agent string similar to how `buildUserAgentString` does it. I had that in a previous version of this PR, but I...