vwifi icon indicating copy to clipboard operation
vwifi copied to clipboard

Modify indexing for function vwifi_interface_add

Open vax-r opened this issue 5 months ago • 5 comments

Summary

Since we implement a counter for wiphy in our project, which is vwifi_wiphy_counter. The relationship between virtual interfaces and wiphy is always one-to-one, so the indexing for virtual interfaces can be the same as wiphy.

Originally, the index for virtual interface is passed as a function parameters into the function vwifi_interface_add(). Now we modify the function, instead of using parameters as index for virtual interface, we use the value of vwifi_wiphy_counter to keep a better consistency.

vax-r avatar Feb 01 '24 09:02 vax-r

Can you check if the proposed change works with namespace?

jserv avatar Feb 01 '24 09:02 jserv

Can you check if the proposed change works with namespace?

Do you mean can we use the same approach on the index for namespace such as ns0 and ns1?

vax-r avatar Feb 01 '24 09:02 vax-r

Do you mean can we use the same approach on the index for namespace such as ns0 and ns1?

Indeed, it is important to recognize that the primary aim of implementing vwifi is to facilitate its deployment within containerized or virtualized environments.

jserv avatar Feb 01 '24 09:02 jserv

Do you mean can we use the same approach on the index for namespace such as ns0 and ns1?

Indeed, it is important to recognize that the primary aim of implementing vwifi is to facilitate its deployment within containerized or virtualized environments.

No problem, let me try to make it possible.

vax-r avatar Feb 01 '24 09:02 vax-r