rv32emu-legacy icon indicating copy to clipboard operation
rv32emu-legacy copied to clipboard

Modify `target_write_u32()` to make 32-bit data output easier

Open kaeteyaruyo opened this issue 5 years ago • 3 comments

  • Modify target_write_u32() function to make 32-bit data output easier
    • User can now output integer or any data type in 32-bit by assigning to (volatile <type> *)0x40000008

kaeteyaruyo avatar Oct 21 '20 16:10 kaeteyaruyo

Please read this carefully: https://chris.beams.io/posts/git-commit/ The subject of git commit message and pull request should summarize the motivation why you would like to make the modification.

jserv avatar Oct 21 '20 17:10 jserv

Sorry I put my purpose in the body but not title... It seems that I cannot modify a commit after I created it. Should I close this PR and create another one with an appropriate commit message?

kaeteyaruyo avatar Oct 21 '20 18:10 kaeteyaruyo

Sorry I put my purpose in the body but not title... It seems that I cannot modify a commit after I created it. Should I close this PR and create another one with an appropriate commit message?

Check this: https://docs.github.com/en/free-pro-team@latest/github/committing-changes-to-your-project/changing-a-commit-message Then, you can do force-push.

jserv avatar Oct 21 '20 18:10 jserv