lkmpg icon indicating copy to clipboard operation
lkmpg copied to clipboard

Fix grammar

Open tzuyichan opened this issue 3 years ago • 3 comments

in the hope ... will -> in the hope that ... would get -> got where are ... gone -> where have ... gone For those not -> For those who are not

tzuyichan avatar Oct 26 '21 21:10 tzuyichan

Can you check grammar with Grammarly and alternatives such as Trinka?

jserv avatar Oct 29 '21 00:10 jserv

Sure, I just did. Unfortunately, Grammarly and Trinka had a hard time picking up on these subtler grammar patterns. I think mixing programming terms and variables in the text also affected their accuracy.

tzuyichan avatar Nov 08 '21 16:11 tzuyichan

@tzuyichan @jserv Other than Grammarly and Trinka, we can also use Linggle or Netspeak to check if certain phrases are commonly used. For example, we can search for the use of in the hope that. Moreover, we can use ? or ... to find one or many words, where have ? gone

As for For those not and For those who are not, I personally think they are both correct. However, if you consider the coherence of these sentences, I would rewrite them as the following:

Original

Those familiar with shell scripts will easily be able to spot them. For those not, the obj-$(CONFIG_FOO) entries you see everywhere expand into obj-y or obj-m, depending on whether the CONFIG_FOO variable has been set to y or m.

New

Those (who are) familiar with shell scripts can easily know the answer. For those who are not, every obj-$(CONFIG_FOO) entries are expanded into obj-y or obj-m, depending on whether we set the CONFIG_FOO variable to y or m.

Because the last sentence was a question, I changed some of the wordings.

leewei05 avatar Mar 23 '22 13:03 leewei05

Thank @tzuyichan for contributing!

jserv avatar Oct 22 '22 16:10 jserv