syslog-ng icon indicating copy to clipboard operation
syslog-ng copied to clipboard

Published 20 hours ago • verified publisher icon syslog-ng

App parser refactor

Open bazsi opened this issue 9 months ago • 3 comments

This PR refactors the app-parser() and has the following changes:

  1. it gets rid off the "*" topic, which basically allowed applications to register to all topics. This does not make much sense for me now, and as far as I understand noone is using it and is undocumented. The only big user is sc4s. @rjha-splunk @ikheifets-splunk please check if this would bother you. My assumption that it is not.

  2. it creates the possibility to create app-parser() like entities by extracting an AppModelObject base class.

  3. it has some refactors as well

bazsi avatar May 15 '24 16:05 bazsi

Build FAILURE

kira-syslogng avatar May 16 '24 04:05 kira-syslogng

@kira-syslogng: retest this please;

bazsi avatar May 16 '24 06:05 bazsi

Thanks for notification @bazsi. We will check it asap

ikheifets-splunk avatar May 16 '24 12:05 ikheifets-splunk

Hello, @bazsi ! Is it possible to download dev build (probably you building on CI)? I think it shouldn't break anything, but anyway we need to run SC4S tests to be sure on 100%.

ikheifets-splunk avatar May 20 '24 09:05 ikheifets-splunk