webpack-virtual-modules
webpack-virtual-modules copied to clipboard
sysgears
Eliminate redundant rebuilds under watch mode in Webpack 5
What's the problem this PR addresses?
Try to eliminate extra rebuilds under watch mode, as issue #121 points out.
How did you fix it?
By making a proxy through WatchFileSystem, patching its aggregated listener with care and filter out virtual files. This way, no rebuild is triggered when the change only includes virtual files' false removals. For details, see https://github.com/sysgears/webpack-virtual-modules/issues/121#issuecomment-1000298229.
There is a regression: test case "should invalidate bundle on dynamic module write" waits indefinitely.
I am uncertain about its intention. Maybe the test passed before is because of the extra rebuild behavior in Webpack 5. Should Webpack rebuild in this case?
There is a regression: test case "should invalidate bundle on dynamic module write" waits indefinitely.
I am uncertain about its intention. Maybe the test passed before is because of the extra rebuild behavior in Webpack 5. Should Webpack rebuild in this case?
The intention of the test is to check that recompilation must happen after one of the source code files is changed on the file system. Maybe the test can be rewritten differently, but checking if recompilation really happens is certainly useful.
There is a regression: test case "should invalidate bundle on dynamic module write" waits indefinitely. I am uncertain about its intention. Maybe the test passed before is because of the extra rebuild behavior in Webpack 5. Should Webpack rebuild in this case?
The intention of the test is to check that recompilation must happen after one of the source code files is changed on the file system. Maybe the test can be rewritten differently, but checking if recompilation really happens is certainly useful.
I understand it better now. For writeModule to work properly, the watch procedure should also be aware of changes on virtual files. In Webpack 5, seemingly only the file/folder watchers are responsible for triggering a rebuild process, as opposed to virtual files are never having actual watchers attached on them. I have to figure out a way to mock this, e.g., calling an arbitrary file watcher manually anyway.
By the way, I will update the code to run the patching function only in Webpack 5, making it compatible with v3 and v4.
Is there any news on this ? I need this PR to be merge to fix a bug that is preventing me from using this plugin :(
