cluster-api-provider-hetzner icon indicating copy to clipboard operation
cluster-api-provider-hetzner copied to clipboard

Published 20 hours ago • verified publisher icon syself

Test whether conditions are set

Open janiskemper opened this issue 2 years ago • 7 comments

Tasks:

  • [x] Test https://github.com/syself/cluster-api-provider-hetzner/pull/942
  • [ ] Search for other conditions and see whether they are being tested or not. Make a list and post it as comment to this issue
  • [ ] Implement tests

janiskemper avatar Sep 21 '23 13:09 janiskemper

I believe that we have not thought about which other conditions we might not have tested. I re-open until that list is done!

janiskemper avatar Oct 16 '23 06:10 janiskemper

  • list of places conditions to be tested -

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L383

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L449

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L489

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L546

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L569

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L136

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L154

  • [ ] https://github.com/syself/cluster-api-provider-hetzner/blob/cb8f7451aa8f4a87d90d11ef9733612767871ef0/pkg/services/hcloud/server/server.go#L174

aniruddha2000 avatar Oct 18 '23 10:10 aniruddha2000

@aniruddha2000 would you say that we have implemented all important ones now?

janiskemper avatar Nov 02 '23 17:11 janiskemper

https://github.com/syself/cluster-api-provider-hetzner/pull/1010 is in progress and i was fixing the mocks IIRC

aniruddha2000 avatar Nov 03 '23 04:11 aniruddha2000

@aniruddha2000 what is the status here?

batistein avatar Nov 10 '23 11:11 batistein

@aniruddha2000 ?

janiskemper avatar Nov 15 '23 09:11 janiskemper

@janiskemper @batistein Ahh sorry I missed that, I need some time to focus on #1010 as that PR is quite big and I have to recap what I did as well

aniruddha2000 avatar Nov 15 '23 11:11 aniruddha2000

@janiskemper I am unsure if it makes sense to keep this issue open. There are many parts which are not covered by envTests yet. Maybe the first step would be to generate a coverage report, so that we know which percentage is covered by tests. Janis, what do you think: Should we keep this issue open?

guettli avatar Aug 15 '24 13:08 guettli

we can still find it even if it is closed. I am not sure if we implemented all these tests mentioned here.

janiskemper avatar Aug 15 '24 15:08 janiskemper